Skip to content

⚠️ Downgrade versions #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

⚠️ Downgrade versions #1634

wants to merge 2 commits into from

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jan 16, 2025 •
edited
Loading

Description

@tmshort's:
"For various compatibility reasons, we need to stick with golang 1.23.2 until certain tools are updated to use a newer version."

  • downgrade go from 1.23.4 to 1.23.2
  • downgrade SDK from 1.39.1 to 1.38
  • downgrade carvel.dev/kapp v0.64.0 to v0.63.3

Closes; #1633

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner January 16, 2025 21:14
@netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit b7666c6
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6789800fe2e1160008af65f4
😎 Deploy Preview https://deploy-preview-1634--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camilamacedo86 camilamacedo86 changed the title Downgrade go version bingo Downgrade go version and carvel.dev/kapp Jan 16, 2025
@camilamacedo86 camilamacedo86 changed the title Downgrade go version and carvel.dev/kapp ⚠️ Downgrade go version and carvel.dev/kapp Jan 16, 2025
@camilamacedo86 camilamacedo86 changed the title ⚠️ Downgrade go version and carvel.dev/kapp ⚠️ Downgrade go version and bingo tools and carvel.dev/kapp Jan 16, 2025
@camilamacedo86 camilamacedo86 changed the title ⚠️ Downgrade go version and bingo tools and carvel.dev/kapp ⚠️ Downgrade versions Jan 16, 2025
@tmshort
Copy link
Contributor

tmshort commented Jan 16, 2025

/hold
Do we really want to revert those depednecies?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2025
@codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.72%. Comparing base (c8380d2) to head (b7666c6).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1634      +/-   ##
==========================================
+ Coverage   66.70%   66.72%   +0.02%     
==========================================
  Files          57       57              
  Lines        4595     4595              
==========================================
+ Hits         3065     3066       +1     
+ Misses       1304     1303       -1     
  Partials      226      226
Flag Coverage Δ
e2e 53.25% <ø> (ø)
unit 53.68% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azych
Copy link
Contributor

azych commented Jan 17, 2025

"For various compatibility reasons, we need to stick with golang 1.23.2 until certain tools are updated to use a newer version."

nit: IMHO would be good to have a little more context provided for those compatibility issues. I don't see it in the original PR that was linked to, maybe we could add it here?

@camilamacedo86 camilamacedo86 mentioned this pull request Jan 17, 2025
Merged
4 tasks
@camilamacedo86
Copy link
Contributor Author

I am closing this one if we decide to downgrade we just re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camilamacedo86 @tmshort @azych